Skip to content

fix: build_filter_conditions utils method #277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 31, 2023

Conversation

aMahanna
Copy link
Member

@aMahanna aMahanna commented Aug 30, 2023

The current implementation of arango.utils.build_filter_conditions() does not support filtering by None values (see the test failures triggered by 75d7d7a)

This method is being used across many of the "simple" methods as of #275

A simple fix is to rely on json.dumps to serialize the arbitrary values into a JSON formatted string

@aMahanna aMahanna self-assigned this Aug 30, 2023
@aMahanna aMahanna added the Ready to Merge Pull request is ready to merge label Aug 30, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #277 (3b048b5) into main (744a6e9) will decrease coverage by 0.24%.
Report is 11 commits behind head on main.
The diff coverage is 92.38%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main     #277      +/-   ##
==========================================
- Coverage   99.01%   98.77%   -0.24%     
==========================================
  Files          26       26              
  Lines        3958     4013      +55     
==========================================
+ Hits         3919     3964      +45     
- Misses         39       49      +10     
Files Changed Coverage Δ
arango/client.py 98.41% <ø> (ø)
arango/http.py 100.00% <ø> (ø)
arango/collection.py 97.59% <91.39%> (-0.92%) ⬇️
arango/exceptions.py 100.00% <100.00%> (ø)
arango/request.py 94.44% <100.00%> (ø)
arango/utils.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

Copy link
Member

@apetenchea apetenchea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@apetenchea apetenchea merged commit fda5a41 into main Aug 31, 2023
@apetenchea apetenchea deleted the fix/build-filter-conditions branch August 31, 2023 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready to Merge Pull request is ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants