Skip to content

Support overload control #237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jun 8, 2023
Merged

Support overload control #237

merged 10 commits into from
Jun 8, 2023

Conversation

tjoubert
Copy link
Contributor

@tjoubert tjoubert commented Dec 13, 2022

Added OverloadControlDatabase, enabling the client to react effectively to potential server overloads.

Requests go through the OverloadControlApiExecutor. For every API call, it allows clients to pass the x-arango-max-queue-time-seconds request header and also return the X-Arango-Queue-Time-Seconds response header if it exists.

Additional tests and documentation added ✔️

@tjoubert tjoubert requested a review from joowani December 13, 2022 15:50
Copy link
Contributor

@joowani joowani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The approach makes sense. Regarding the name QueueTimeApiExecutor, perhaps we could rename it to something more generic so we can reuse to support other headers in the future (e.g. ApiExecutorV2)

@joowani joowani force-pushed the support-overload-control branch from 26bf791 to f731023 Compare February 1, 2023 22:56
@apetenchea apetenchea self-assigned this Jun 5, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jun 7, 2023

Codecov Report

Merging #237 (8b09e07) into main (52648c7) will increase coverage by 0.01%.
The diff coverage is 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main     #237      +/-   ##
==========================================
+ Coverage   98.57%   98.58%   +0.01%     
==========================================
  Files          26       26              
  Lines        3858     3899      +41     
==========================================
+ Hits         3803     3844      +41     
  Misses         55       55              
Impacted Files Coverage Δ
arango/database.py 99.86% <100.00%> (+<0.01%) ⬆️
arango/exceptions.py 100.00% <100.00%> (ø)
arango/executor.py 99.47% <100.00%> (+0.07%) ⬆️

@apetenchea apetenchea marked this pull request as ready for review June 8, 2023 13:57
@CryptoNinjaGeek CryptoNinjaGeek merged commit f330774 into main Jun 8, 2023
@CryptoNinjaGeek CryptoNinjaGeek deleted the support-overload-control branch June 8, 2023 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants