-
Notifications
You must be signed in to change notification settings - Fork 78
Support overload control #237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The approach makes sense. Regarding the name QueueTimeApiExecutor
, perhaps we could rename it to something more generic so we can reuse to support other headers in the future (e.g. ApiExecutorV2)
26bf791
to
f731023
Compare
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## main #237 +/- ##
==========================================
+ Coverage 98.57% 98.58% +0.01%
==========================================
Files 26 26
Lines 3858 3899 +41
==========================================
+ Hits 3803 3844 +41
Misses 55 55
|
Added
OverloadControlDatabase
, enabling the client to react effectively to potential server overloads.Requests go through the
OverloadControlApiExecutor
. For every API call, it allows clients to pass thex-arango-max-queue-time-seconds
request header and also return theX-Arango-Queue-Time-Seconds
response header if it exists.Additional tests and documentation added ✔️