3.10: Read from Followers (allow dirty read) #222
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #222 +/- ##
==========================================
- Coverage 99.23% 99.15% -0.08%
==========================================
Files 26 26
Lines 3770 3776 +6
==========================================
+ Hits 3741 3744 +3
- Misses 29 32 +3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
joowani
reviewed
Oct 4, 2022
Thanks @joowani. I have updated the default value of the allow_dirty_read parameter to False. |
joowani
reviewed
Oct 4, 2022
| @@ -358,6 +359,8 @@ def execute( | |||
| query will not make it into the RocksDB block cache if not already | |||
| in there, thus leaving more room for the actual hot set. | |||
| :type fill_block_cache: bool | |||
| :param allow_dirty_read: Allow reads from followers in a cluster. | |||
| :type allow_dirty_read: bool | None | |||
There was a problem hiding this comment.
nit: allow_dirty_read: bool. Same for others.
joowani
approved these changes
Oct 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
allow_dirty_readoptional parameter to methods for the following:GET /_api/document)PUT /_api/document?onlyget=true)POST /_api/cursor)GET /_api/edges)POST /_api/transaction/begin etc.)https://github.com/arangodb/docs/blob/main/3.10/release-notes-api-changes310.md#read-from-followers