Add 'read_timeout' option in client.py #213
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joowani
reviewed
Aug 7, 2022
Codecov Report
@@ Coverage Diff @@
## main #213 +/- ##
==========================================
- Coverage 99.86% 99.86% -0.01%
==========================================
Files 26 26
Lines 3735 3731 -4
==========================================
- Hits 3730 3726 -4
Misses 5 5
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
request_timeoutproperty toArangoClientto overwriteDefaultHTTPClient.REQUEST_TIMEOUTrequest_timeoutconstructor parameter inArangoClientto initializerequest_timeoutproperty. The default value for this parameter is -1. Any other value supplied, includingNonewill overwriteDefaultHTTPClient.REQUEST_TIMEOUT# type: ignoreto lines 141 and 146 because they failedmypy. However, they work perfectly well when tested. Any suggestions here is very much appreciated.