Skip to content

Breaking change: Removed discontinued collection export method #211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Aug 7, 2022

Conversation

tjoubert
Copy link
Contributor

@tjoubert tjoubert commented Aug 1, 2022

Solves #210

  • Removed collection.export() method
  • Consumers should execute AQL into a Cursor

@codecov-commenter
Copy link

Codecov Report

Merging #211 (1d4bbb8) into main (76ca077) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #211      +/-   ##
==========================================
- Coverage   99.86%   99.86%   -0.01%     
==========================================
  Files          26       26              
  Lines        3735     3717      -18     
==========================================
- Hits         3730     3712      -18     
  Misses          5        5              
Impacted Files Coverage Δ
arango/collection.py 99.75% <ø> (-0.01%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us.

@tjoubert tjoubert requested review from joowani and aMahanna August 1, 2022 15:48
Copy link
Contributor

@joowani joowani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR

@joowani joowani merged commit 0c51020 into main Aug 7, 2022
@joowani joowani deleted the DE-281-discontinue-collection-export branch August 7, 2022 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants