Skip to content

Prevent batch_size parameter usage when overwrite is set to True in bulk_import #209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 28, 2022

Conversation

aMahanna
Copy link
Member

@aMahanna aMahanna commented Jun 28, 2022

Now that batch_size has been introduced to import_bulk(), we should be checking that users don't use both the overwrite and the batch_size parameters in the same call.

If server-side batching is ever introduced to /_api/import, then this restriction could most likely be lifted.

Warrants a 7.4.1 release

@codecov-commenter
Copy link

codecov-commenter commented Jun 28, 2022

Codecov Report

Merging #209 (06b76ee) into main (917f699) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #209   +/-   ##
=======================================
  Coverage   99.86%   99.86%           
=======================================
  Files          26       26           
  Lines        3732     3735    +3     
=======================================
+ Hits         3727     3730    +3     
  Misses          5        5           
Impacted Files Coverage Δ
arango/collection.py 99.75% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 917f699...06b76ee. Read the comment docs.

@aMahanna aMahanna self-assigned this Jun 28, 2022
@aMahanna aMahanna requested a review from joowani June 28, 2022 21:35
Copy link
Contributor

@joowani joowani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of nits on the docstrings (I'd like to be picky with documentation as much as I am with code). Thank you for making this change.

@aMahanna aMahanna requested a review from joowani June 28, 2022 22:28
@joowani joowani changed the title cover import bulk edge case Prevent batch_size parameter usage when overwrite is set to True in bulk_import Jun 28, 2022
@joowani joowani merged commit 76ca077 into main Jun 28, 2022
@aMahanna aMahanna deleted the fix/import-bulk-edge-case branch June 28, 2022 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants