Improve array iterator #19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For compact arrays, the old implementation was quadratic, resulting in absolutely terrible performance for large arrays.
rashtao
requested changes
Mar 24, 2020
|
You are right, sorry! Seems like the IDE did not pick up my latest changes for my last test run before committing. Should be fixed now. |
rashtao
approved these changes
Mar 24, 2020
|
Thanks! Do you have an ETA for a new release that contains this fix? |
|
@mpoeter releasing now... Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For compact arrays, the old implementation was quadratic, resulting in absolutely terrible performance for large arrays.