Add tags support #15
Merged
Add tags support #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@siilike thanks for contributing, but we have to wait for the specification proposal update to be accepted (arangodb/velocypack#34) before moving forward with the java implementation. |
This was referenced Dec 9, 2019
|
Specification updated, pull request updated, please review. |
|
@siilike can you please rebase the PR on master? May you also remove the gradle files? Also I would like to keep only 1 building tool (maven), since maintaining maven and gradle would add unnecessary additional complexity. |
|
Updated! |
rashtao
requested changes
Dec 20, 2019
src/main/java/com/arangodb/velocypack/exception/VPackException.java
Outdated
Show resolved
Hide resolved
|
Updated! |
rashtao
requested changes
Dec 20, 2019
src/main/java/com/arangodb/velocypack/exception/VPackException.java
Outdated
Show resolved
Hide resolved
|
Updated! |
rashtao
approved these changes
Dec 20, 2019
|
Great, thanks! |
Thank you for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds tags support as in arangodb/velocypack#34. A few things might still be missing.
Additionally it adds (basic) Gradle support (would be great to have it even if you don't want to switch from Maven), avoids unnecessary allocation of none Slices and copying in Slice.equals() and Slice.hashCode().
Based on #14.