-
Notifications
You must be signed in to change notification settings - Fork 81
GT-575 Transparent compression of requests and responses #598
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
2210c25
GT-575 Transparent compression of requests and responses
jwierzbo 1478f33
test
jwierzbo b63d749
extend ci
jwierzbo 5aaecea
tests
jwierzbo d202806
tests
jwierzbo 6ec5e7e
fix
jwierzbo b1b3a22
GT-593 External versioning
jwierzbo 9ffe423
refactor
jwierzbo a7620f2
error handling
jwierzbo 11ad80a
cleaning
jwierzbo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,122 @@ | ||
// | ||
// DISCLAIMER | ||
// | ||
// Copyright 2024 ArangoDB GmbH, Cologne, Germany | ||
// | ||
// Licensed under the Apache License, Version 2.0 (the "License"); | ||
// you may not use this file except in compliance with the License. | ||
// You may obtain a copy of the License at | ||
// | ||
// http://www.apache.org/licenses/LICENSE-2.0 | ||
// | ||
// Unless required by applicable law or agreed to in writing, software | ||
// distributed under the License is distributed on an "AS IS" BASIS, | ||
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
// See the License for the specific language governing permissions and | ||
// limitations under the License. | ||
// | ||
// Copyright holder is ArangoDB GmbH, Cologne, Germany | ||
// | ||
|
||
package connection | ||
|
||
import ( | ||
"compress/zlib" | ||
"fmt" | ||
"io" | ||
|
||
"github.com/arangodb/go-driver/v2/log" | ||
) | ||
|
||
type Compression interface { | ||
ApplyRequestHeaders(r Request) | ||
ApplyRequestCompression(r *httpRequest, rootWriter io.Writer) (io.WriteCloser, error) | ||
} | ||
|
||
func newCompression(config *CompressionConfig) Compression { | ||
if config == nil { | ||
return noCompression{} | ||
} else if config.CompressionType == "gzip" { | ||
return gzipCompression{config: config} | ||
} else if config.CompressionType == "deflate" { | ||
return deflateCompression{config: config} | ||
} else { | ||
log.Error(fmt.Errorf("unknown compression type: %s", config.CompressionType), "") | ||
return noCompression{config: config} | ||
} | ||
} | ||
|
||
type gzipCompression struct { | ||
config *CompressionConfig | ||
} | ||
|
||
func (g gzipCompression) ApplyRequestHeaders(r Request) { | ||
if g.config != nil && g.config.ResponseCompressionEnabled { | ||
if g.config.CompressionType == "gzip" { | ||
r.AddHeader("Accept-Encoding", "gzip") | ||
} | ||
} | ||
} | ||
|
||
func (g gzipCompression) ApplyRequestCompression(r *httpRequest, rootWriter io.Writer) (io.WriteCloser, error) { | ||
config := g.config | ||
|
||
if config != nil && config.RequestCompressionEnabled { | ||
if config.CompressionType == "deflate" { | ||
r.headers["Content-Encoding"] = "deflate" | ||
|
||
zlibWriter, err := zlib.NewWriterLevel(rootWriter, config.RequestCompressionLevel) | ||
if err != nil { | ||
log.Errorf(err, "error creating zlib writer") | ||
return nil, err | ||
} | ||
|
||
return zlibWriter, nil | ||
} | ||
} | ||
|
||
return nil, nil | ||
} | ||
|
||
type deflateCompression struct { | ||
config *CompressionConfig | ||
} | ||
|
||
func (g deflateCompression) ApplyRequestHeaders(r Request) { | ||
if g.config != nil && g.config.ResponseCompressionEnabled { | ||
if g.config.CompressionType == "deflate" { | ||
r.AddHeader("Accept-Encoding", "deflate") | ||
} | ||
} | ||
} | ||
|
||
func (g deflateCompression) ApplyRequestCompression(r *httpRequest, rootWriter io.Writer) (io.WriteCloser, error) { | ||
config := g.config | ||
|
||
if config != nil && config.RequestCompressionEnabled { | ||
if config.CompressionType == "deflate" { | ||
r.headers["Content-Encoding"] = "deflate" | ||
|
||
zlibWriter, err := zlib.NewWriterLevel(rootWriter, config.RequestCompressionLevel) | ||
if err != nil { | ||
log.Errorf(err, "error creating zlib writer") | ||
return nil, err | ||
} | ||
|
||
return zlibWriter, nil | ||
} | ||
} | ||
|
||
return nil, nil | ||
} | ||
|
||
type noCompression struct { | ||
config *CompressionConfig | ||
} | ||
|
||
func (g noCompression) ApplyRequestHeaders(r Request) { | ||
} | ||
|
||
func (g noCompression) ApplyRequestCompression(r *httpRequest, rootWriter io.Writer) (io.WriteCloser, error) { | ||
return nil, nil | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.