Test ArangoDatabaseTest.getCollectionsExcludeSystem() fails when packaging master branch

[rkhaja]

When packaging the master branch of the arangodb-java-driver, the ArangoDatabaseTest.getCollectionsExcludeSystem() fails.

Here are details of the failure:

getCollectionsExcludeSystem[0](com.arangodb.ArangoDatabaseTest)  Time elapsed: 0.023 sec  <<< FAILURE!
java.lang.AssertionError: 
Expected: is <0>
     but: was <2>
	at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20)
	at org.junit.Assert.assertThat(Assert.java:956)
	at org.junit.Assert.assertThat(Assert.java:923)
	at com.arangodb.ArangoDatabaseTest.getCollectionsExcludeSystem(ArangoDatabaseTest.java:514)
...

[rkhaja]

It appears that the source of this problem is a previously run test.

Here is the source for ArangoGraphTest.drop():

	@Test
	public void drop() {
		final String edgeCollection  = "edge_drop";
		final String vertexCollection = "vertex_drop";
		final String graph = GRAPH_NAME + "_drop";
		final GraphEntity result = db.graph(graph).create(Collections
				.singleton(new EdgeDefinition().collection(edgeCollection).from(vertexCollection).to(vertexCollection)));
		assertThat(result, is(notNullValue()));
		db.graph(graph).drop();
		assertThat(db.collection(edgeCollection).exists(), is(true));
		assertThat(db.collection(vertexCollection).exists(), is(true));
	}

This test creates a graph with 2 collections: edge_drop and vertex_drop, then drops the graph and checks that the collections that were created still exist. Thus 2 collections are left behind as a result of running this test.

When ArangoDatabaseTest.getCollectionsExcludeSystem() is run, it expects that the number of collections should be 0, but instead gets 2.

Here is the source of ArangoDatabaseTest.getCollectionsExcludeSystem()

        @Test
        public void getCollectionsExcludeSystem() {
                try {
                        final CollectionsReadOptions options = new CollectionsReadOptions().excludeSystem(true);
                        final Collection<CollectionEntity> systemCollections = db.getCollections(options);
                        
                        assertThat(systemCollections.size(), is(0));
                        db.createCollection(COLLECTION_NAME + "1", null);
                        db.createCollection(COLLECTION_NAME + "2", null);
                        final Collection<CollectionEntity> collections = db.getCollections(options);
                        assertThat(collections.size(), is(2));
                        assertThat(collections, is(notNullValue()));
                } catch (final ArangoDBException e) {
                  System.out.println(e.getErrorMessage());
                } finally {
                	try {
                		db.collection(COLLECTION_NAME + "1").drop();
                        db.collection(COLLECTION_NAME + "2").drop();
                	} catch (final ArangoDBException e) {
                	}
                }
        }

Above, systemCollections is really misnamed, since it should not contain any system collections, because excludeSystem(true) is specified.

In anycase, the systemCollections variable contains the collections: edge_drop and vertex_drop. I think to fix this problem, that an @afterclass test fixture to cleanup the residual collections should be implemented.

[rkhaja]

Closing issue, since pull request #275 was merged.

[rkhaja]

Thank you!