Skip to content

CI setup #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

CI setup #2

wants to merge 1 commit into from

Conversation

yim-lee
Copy link
Member

@yim-lee yim-lee commented May 10, 2023

Motivation:
swift-openapi-runtime is private, so it can't be accessed anonymously and CI fails.

Modifications:

  • Change to use SSH git URL for swift-openapi-runtime
  • Set up SSH access in CI temporarily until swift-openapi-runtime becomes public.

@yim-lee
CI setup
accc456 
Motivation:
swift-openapi-runtime is private, so it can't be accessed anonymously and CI fails.

Modifications:
- Change to use SSH git URL for swift-openapi-runtime
- Set up SSH access in CI temporarily until swift-openapi-runtime becomes public.
@yim-lee
Copy link
Member Author

yim-lee commented May 10, 2023

@swift-server-bot test this please

@czechboy0
Copy link
Contributor

Would a gitconfig file on CI make this work, by rewriting URLs automatically?

[url "git@github.com:"]
	insteadOf = https://github.com/

We could include this in the docker-compute setup, if that'd help? cc @simonjbeaumont

@yim-lee
Copy link
Member Author

yim-lee commented May 10, 2023

IIUC the gitconfig approach would replace all github.com repo URLs and not just swift-openapi-runtime. I don't know if that's ideal (whether anonymous access is preferred over SSH).

I also think having it in Package.swift is more "in your face" thus harder to forget to change it later.

yim-lee
yim-lee commented May 10, 2023
View reviewed changes
Package.swift
.package(url: "https://github.com/apple/swift-openapi-runtime", .upToNextMinor(from: "0.1.0")),
// FIXME: swift-openapi-runtime is private, so we can't access it anonymously yet
//.package(url: "https://github.com/apple/swift-openapi-runtime", .upToNextMinor(from: "0.1.0")),
.package(url: "git@github.com:apple/swift-openapi-runtime.git", .upToNextMinor(from: "0.1.0")),
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI @tomerd - have to apply that same CI hack for these repos

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems fine for now, we can change later when made public?

@simonjbeaumont
Copy link
Collaborator

I think we can solve this and keep the only changes in the docker-compose.yaml, which means we don't have to work with any temporary hacks in either the Jenkins config or the Package.swift.

Opened PR #3 which should resolve this, in that way.

@yim-lee
Copy link
Member Author

yim-lee commented May 11, 2023

Closing this in favor of #3

@yim-lee yim-lee closed this May 11, 2023
@yim-lee yim-lee deleted the yim-lee-patch-2 branch May 11, 2023 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomerd tomerd tomerd left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yim-lee @czechboy0 @simonjbeaumont @tomerd