Skip to content

Add 5.4, 5.5, and main CI #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 1, 2021
Merged

Add 5.4, 5.5, and main CI #12

merged 1 commit into from
Jun 1, 2021

Conversation

Lukasa
Copy link
Contributor

@Lukasa Lukasa commented May 27, 2021

Adds Swift 5.4, 5.5, and main to CI.

@Lukasa Lukasa added the semver/none No version bump required. label May 27, 2021
@Lukasa Lukasa requested a review from tomerd May 27, 2021 13:42
@Lukasa
Copy link
Contributor Author

Lukasa commented May 27, 2021

@tomerd Hey Tom this also needs some updates to the CI:

  1. Add a 5.4 job as Required
  2. Add a 5.5 job as Not Required
  3. Add a main job as Not Required

@tomerd
Copy link
Member

tomerd commented May 27, 2021

@swift-server-bot test this please

@tomerd
Copy link
Member

tomerd commented May 27, 2021

@Lukasa ci jobs added, you should be able to set required/no-required yourself via GitHub

@tomerd
Copy link
Member

tomerd commented May 27, 2021

also looks like the Dockerfile needs to be updated to reflect rubygems changes, we needed to do similar thing with swift-nio and other packages

@Lukasa Lukasa force-pushed the cb-update-docker branch 2 times, most recently from d668a9a to 1c408c9 Compare June 1, 2021 09:53
Copy link
Contributor

@glbrntt glbrntt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Lukasa Lukasa merged commit f881e6c into apple:main Jun 1, 2021
@Lukasa Lukasa deleted the cb-update-docker branch June 1, 2021 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver/none No version bump required.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants