Skip to content

Update to Sendable Baggage #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 29, 2022
Merged

Update to Sendable Baggage #60

merged 1 commit into from
Jan 29, 2022

Conversation

ktoso
Copy link
Member

@ktoso ktoso commented Jan 29, 2022

No description provided.

@ktoso ktoso requested review from slashmo and tomerd January 29, 2022 02:08
slashmo
slashmo approved these changes Jan 29, 2022
View reviewed changes
Copy link
Collaborator

@slashmo slashmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slashmo
Copy link
Collaborator

slashmo commented Jan 29, 2022

@ktoso This will be tagged as 0.3.0 though, right?

@ktoso
Copy link
Member Author

ktoso commented Jan 29, 2022

Yeah this would be 0.3 of tracing -- that works right?
Also for your Tracer impls

@slashmo
Copy link
Collaborator

slashmo commented Jan 29, 2022

Yeah this would be 0.3 of tracing -- that works right?
Also for your Tracer impls

Yep, OpenTelemetry Swift already supports Sendable, so for me personally it doesn't make a difference if this is gonna be tagged as 0.2.3 or 0.3.0, but we should still do 0.3.0 as the experience might differ for others and it's nice to have release versions of the Baggage and Tracing repos aligned.

@ktoso
Copy link
Member Author

ktoso commented Jan 29, 2022

yeah it makes sense to tag them in unison

@ktoso ktoso merged commit ef8ba96 into main Jan 29, 2022
@ktoso ktoso deleted the ktoso-patch-1 branch January 29, 2022 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slashmo slashmo slashmo approved these changes

@tomerd tomerd Awaiting requested review from tomerd

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ktoso @slashmo