remove clock protocol, use autoclosure "now" instant #120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktoso
force-pushed
the
wip-instants
branch
2 times, most recently
from
150a26e to
d816c20
Compare
**Motivation:** we don't need the clock protocol, but we do need the default clock to provide an instant. We also add time to recordError in this PR
|
We have discussed this one with @fabianfett yesterday at length, it'll work nicely |
|
I'll merge since I want to get the documentation / reference docs revived today, but post-merge review is welcome -- this mostly just swaps |
fabianfett
reviewed
Apr 13, 2023
| @@ -84,19 +84,19 @@ public struct NoOpTracer: LegacyTracer { | |||
| } | |||
| } | |||
|
|
|||
| public func end<Clock: TracerClock>(clock: Clock) { | |||
| public func end<Instant: TracerInstant>(at instant: Instant) { | |||
There was a problem hiding this comment.
do we need an @autoclosure here as well?
There was a problem hiding this comment.
Oh excellent, thanks! Following up right away
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
we don't need the clock protocol, but we do need the default clock to provide an instant.
We also add time to recordError in this PR
Resolves #119
Resolves #108