Remove Sendable from AsyncBufferedByteIterator
#220
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phausler
reviewed
Oct 20, 2022
FranzBusch
force-pushed
the
fb-remove-sendable-buffered-byte
branch
from
bc8ef67 to
1016fdc
Compare
# Motivation I raise on the pitch of `AsyncBufferedByteIterator` on the forums that I think the iterator must not be `Sendable`. The reasoning for this is twofold. First, an iterator is the connection of a consumer to the `AsyncSequence`; therefore, iterators should not be shared since it breaks that assumption. Secondly, the implementation of the `AsyncBufferedByteIterator` can be more straight forward since we don't have to check for unique ownership of the storage. # Modification Remove the `Sendable` conformances from `AsyncBufferedByteIterator`.
FranzBusch
force-pushed
the
fb-remove-sendable-buffered-byte
branch
from
1016fdc to
ebc4aca
Compare
tcldr
pushed a commit
to tcldr/swift-async-algorithms
that referenced
this pull request
Nov 3, 2022
# Motivation I raise on the pitch of `AsyncBufferedByteIterator` on the forums that I think the iterator must not be `Sendable`. The reasoning for this is twofold. First, an iterator is the connection of a consumer to the `AsyncSequence`; therefore, iterators should not be shared since it breaks that assumption. Secondly, the implementation of the `AsyncBufferedByteIterator` can be more straight forward since we don't have to check for unique ownership of the storage. # Modification Remove the `Sendable` conformances from `AsyncBufferedByteIterator`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
I raise on the pitch of
AsyncBufferedByteIteratoron the forums that I think the iterator must not beSendable. The reasoning for this is twofold. First, an iterator is the connection of a consumer to theAsyncSequence; therefore, iterators should not be shared since it breaks that assumption. Secondly, the implementation of theAsyncBufferedByteIteratorcan be more straight forward since we don't have to check for unique ownership of the storage.Modification
Remove the
Sendableconformances fromAsyncBufferedByteIterator.