Skip to content

Update typescript-eslint monorepo to v6 (major) #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 1, 2023

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jul 15, 2023

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
@typescript-eslint/eslint-plugin 5.62.0 -> 6.2.1 age adoption passing confidence
@typescript-eslint/parser 5.62.0 -> 6.2.1 age adoption passing confidence

Release Notes

typescript-eslint/typescript-eslint (@​typescript-eslint/eslint-plugin)

v6.2.1

Compare Source

Bug Fixes
  • eslint-plugin: [no-inferrable-types] apply also for parameter properties (#​7288) (67f93b1)
  • scope-manager: correct decorators(.length) check in ClassVisitor for methods (#​7334) (abbb6c2)

You can read about our versioning strategy and releases on our website.

v6.2.0

Compare Source

Bug Fixes
  • eslint-plugin: [member-ordering] account for repeated names (#​6864) (d207b59)
  • eslint-plugin: [no-unsafe-enum-comparison] exempt bit shift operators (#​7074) (b3e0e75)
  • eslint-plugin: [prefer-nullish-coalescing] handle case when type of left side is null or undefined (#​7225) (b62affe)
  • eslint-plugin: use a default export for the rules type (#​7266) (af77a1d)
Features
  • eslint-plugin: [class-methods-use-this] add extension rule (#​6457) (18ea3b1)
  • eslint-plugin: sync getFunctionHeadLoc implementation with upstream (#​7260) (f813147)

You can read about our versioning strategy and releases on our website.

v6.1.0

Compare Source

Bug Fixes
  • eslint-plugin: [comma-dangle] fixed crash from undefined predicate.ignore (#​7223) (d368164)
  • eslint-plugin: [no-floating-promises] false negative calling .then with second argument undefined (#​6881) (606a52c), closes #​6850
  • eslint-plugin: [no-floating-promises] finally should be transparent to unhandled promises (#​7092) (2a4421c)
  • eslint-plugin: [no-unnecessary-type-constraint] correctly fix in cts/mts files (#​6795) (1404796)
  • eslint-plugin: [no-unused-vars] check if any variable definition is exported (#​6873) (587ac30), closes #​6188
  • eslint-plugin: fix schemas across several rules and add schema tests (#​6947) (dd31bed)
  • eslint-plugin: include the rules types in the package (#​7215) (a3da11d)
Features
  • typescript-estree: add EXPERIMENTAL_useProjectService option to use TypeScript project service (#​6754) (6d3d162)

You can read about our versioning strategy and releases on our website.

v6.0.0

Compare Source

Bug Fixes
  • bumped ts-api-utils to 0.0.39 (#​6497) (217c710)
  • correct handling of additionalProperties in object schemas (#​6939) (489c7a5)
  • correct lint error after merge (277fdb5)
  • eslint-plugin: [explicit-module-boundary-types] remove shouldTrackReferences option from schema (#​5399) (6d32734)
  • eslint-plugin: allow parser@^6.0.0 (#​6630) (92908bd)
  • eslint-plugin: remove valid-typeof disable in eslint-recommended (#​5381) (b82df5e)
  • fix illegal decorator check (#​6723) (c456f8c)
  • rename typeParameters to typeArguments where needed (#​5384) (08d757b)
  • replace tsutils with ts-api-tools (#​6428) (79327b4)
  • type-utils: treat intrinsic types as if they are from lib and never match error types (#​6869) (ecb57de)
  • typescript-estree: account for namespace nesting in AST conversion (#​6272) (09e3877)
  • update exports field in package.json files (#​6550) (53776c2)
chore
Features
BREAKING CHANGES
  • eslint-plugin: Adds an additional class of checks to the rule
  • drop support for ESLint v6
  • drops support for node v17
  • Bumps the minimum supported range and removes handling for old versions
  • drops support for node v12

You can read about our versioning strategy and releases on our website.

typescript-eslint/typescript-eslint (@​typescript-eslint/parser)

v6.2.1

Compare Source

Note: Version bump only for package @​typescript-eslint/parser

You can read about our versioning strategy and releases on our website.

v6.2.0

Compare Source

Note: Version bump only for package @​typescript-eslint/parser

You can read about our versioning strategy and releases on our website.

v6.1.0

Compare Source

Features
  • typescript-estree: add EXPERIMENTAL_useProjectService option to use TypeScript project service (#​6754) (6d3d162)

You can read about our versioning strategy and releases on our website.

v6.0.0

Compare Source

Bug Fixes
chore
Features
BREAKING CHANGES
  • drop support for ESLint v6
  • drops support for node v17
  • drops support for node v12

You can read about our versioning strategy and releases on our website.


Configuration

📅 Schedule: Branch creation - "every weekend" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot requested a review from a team as a code owner July 15, 2023 01:13
@renovate
Copy link
Contributor Author

renovate bot commented Jul 15, 2023

⚠ Artifact update problem

Renovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is.

♻ Renovate will retry this branch, including artifacts, only when one of the following happens:

  • any of the package files in this branch needs updating, or
  • the branch becomes conflicted, or
  • you click the rebase/retry checkbox if found above, or
  • you rename this PR's title to start with "rebase!" to trigger it manually

The artifact failure details are included below:

File name: package-lock.json
/usr/local/bin/docker: line 4: .: filename argument required
.: usage: . filename [arguments]
[17:23:08.746] INFO (43): Downloading file ...
    url: "https://github.com/containerbase/node-prebuild/releases/download/18.17.0/node-18.17.0-focal-x86_64.tar.xz.sha512"
    output: "/tmp/worker/1ae3eb/ff1f64/cache/containerbase/4f1b66de1eebc4e832e9ad5a012165a5e79cd3b1c3892eb6646e768a14a95e7c/node-18.17.0-focal-x86_64.tar.xz.sha512"
[17:23:08.852] INFO (43): Download completed  in 106ms.
[17:23:08.971] INFO (59): Downloading file ...
    url: "https://github.com/containerbase/node-prebuild/releases/download/18.17.0/node-18.17.0-focal-x86_64.tar.xz"
    output: "/tmp/worker/1ae3eb/ff1f64/cache/containerbase/d71155bd68a6dac4a334976c5d82cd47e91bf95aa8811a4ec27c615d8d82df76/node-18.17.0-focal-x86_64.tar.xz"
[17:23:09.260] INFO (59): Download completed  in 289ms.
npm ERR! code ERESOLVE
npm ERR! ERESOLVE could not resolve
npm ERR! 
npm ERR! While resolving: eslint-plugin-typescript-sort-keys@2.3.0
npm ERR! Found: @typescript-eslint/parser@6.2.1
npm ERR! node_modules/@typescript-eslint/parser
npm ERR!   dev @typescript-eslint/parser@"6.2.1" from the root project
npm ERR!   peer @typescript-eslint/parser@"^6.0.0 || ^6.0.0-alpha" from @typescript-eslint/eslint-plugin@6.2.1
npm ERR!   node_modules/@typescript-eslint/eslint-plugin
npm ERR!     dev @typescript-eslint/eslint-plugin@"6.2.1" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer @typescript-eslint/parser@"^1 || ^2 || ^3 || ^4 || ^5" from eslint-plugin-typescript-sort-keys@2.3.0
npm ERR! node_modules/eslint-plugin-typescript-sort-keys
npm ERR!   dev eslint-plugin-typescript-sort-keys@"2.3.0" from the root project
npm ERR! 
npm ERR! Conflicting peer dependency: @typescript-eslint/parser@5.62.0
npm ERR! node_modules/@typescript-eslint/parser
npm ERR!   peer @typescript-eslint/parser@"^1 || ^2 || ^3 || ^4 || ^5" from eslint-plugin-typescript-sort-keys@2.3.0
npm ERR!   node_modules/eslint-plugin-typescript-sort-keys
npm ERR!     dev eslint-plugin-typescript-sort-keys@"2.3.0" from the root project
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR! 
npm ERR! 
npm ERR! For a full report see:
npm ERR! /tmp/worker/1ae3eb/ff1f64/cache/others/npm/_logs/2023-07-31T17_23_14_450Z-eresolve-report.txt

npm ERR! A complete log of this run can be found in: /tmp/worker/1ae3eb/ff1f64/cache/others/npm/_logs/2023-07-31T17_23_14_450Z-debug-0.log

@renovate renovate bot force-pushed the renovate/major-typescript-eslint-monorepo branch 4 times, most recently from b62866b to 7b0e0f2 Compare July 24, 2023 18:56
@renovate renovate bot force-pushed the renovate/major-typescript-eslint-monorepo branch from 7b0e0f2 to cc34b50 Compare July 31, 2023 17:23
@trevor-scheer
Copy link
Contributor

@martinnabhan can we drop the eslint-plugin-typescript-sort-keys lint rule? It's incompatible with typescript-eslint@6 and looks like it might be stuck for now due to its dependencies on other old packages.
infctr/eslint-plugin-typescript-sort-keys#64

@renovate
Copy link
Contributor Author

renovate bot commented Aug 1, 2023

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

Warning: custom changes will be lost.

@martinnabhan martinnabhan enabled auto-merge (squash) August 1, 2023 01:28
@martinnabhan martinnabhan merged commit 97b615d into main Aug 1, 2023
@martinnabhan martinnabhan deleted the renovate/major-typescript-eslint-monorepo branch August 1, 2023 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants