Fix: Remove duplicated docs and fix constructors #1702
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanpoulain
approved these changes
Jan 24, 2023
|
It keeps reappearing! Thank you @timkrase. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The docs page for operations contains a part that's a duplicate from the controllers page and the the controllers page is not using the new constructor syntax for all code examples.
@alanpoulain fixed both of this with #1439 but #1426 (which was created earlier and contained changes in that part) seems to be merged afterwards and probably reintroduced the problem.
This PR removes the duplicated part from the operations page again (which is still available at the controllers doc page and changes the constructor on the controller docs page.