Skip to content

Add disable pagination for specific operation #1700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 24, 2023

Conversation

Enz000
Copy link
Contributor

@Enz000 Enz000 commented Jan 21, 2023

No description provided.

Comment on lines 112 to 113
#[ApiResource]
#[GetCollection(paginationEnabled: false)]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We prefer to use only the #[ApiResource] attribute in the documentation (with the operations argument).

Copy link
Contributor Author

@Enz000 Enz000 Jan 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.
I saw a lot of parts of code in the documentation when a multiple #[ApiResource] is used like in #1686
Do you think it's useful to do a dedicated PR for using the operations argument instead? in the example bellow ? Thank you Alain👍🏻
Capture d’écran 2023-01-23 à 21 39 20

@alanpoulain alanpoulain changed the base branch from 3.0 to 3.1 January 24, 2023 13:45
@alanpoulain alanpoulain merged commit 45dc5d1 into api-platform:3.1 Jan 24, 2023
@alanpoulain
Copy link
Member

Thank you @Enz000.

@Enz000 Enz000 deleted the patch-3 branch January 24, 2023 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants