feat(doc): use snake case names on operation sub options #1536
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this is too much. Adding a note in |
|
I disagree. It's easier and more easily understandable to show by example than describe it in verbose text. The work is already done. It just needs merging. 😄 |
|
You can show by example in
Sure, but it needs to be maintained too 😉 Anyway, this is my opinion, maybe @dunglas or someone else prefers to merge as is. |
|
From your last comment it sounds if the additional header was the primary concern. I removed the header and moved the text and example into the |
vincentchalamon
requested changes
Jul 20, 2022
|
Thanks @gnito-org |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It took me too much frustration and digging to accidentally discover this.