Skip to content

docs: Upgrade Filters documentation to use php8 attributes instead of annotations #1458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
Oct 30, 2021
Merged

docs: Upgrade Filters documentation to use php8 attributes instead of annotations #1458

merged 20 commits into from
Oct 30, 2021

Conversation

ES-Six
Copy link
Contributor

@ES-Six ES-Six commented Oct 30, 2021

This PR is intended to enhance the Filter documentation by converting Doctrine annotations to PHP8 attributes since doctrine now supports well the PHP8 attributes:

Here is the list of modifications:

  • Every doctrine annotations in the examples have been replaced by doctrine attributes (as in the latest doctrine version, attribute usage is now enabled by default).
  • Entity properties typing is now enforced.
  • The Doctrine ORM Filter example (UserFilter.php) shows how to create and use a custom attribute instead of how to create a custom annotation.

@ES-Six ES-Six changed the base branch from main to 2.6 October 30, 2021 11:47
Copy link
Member

@dunglas dunglas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

ES-Six and others added 9 commits October 30, 2021 22:11
Co-authored-by: Kévin Dunglas <kevin@dunglas.fr>
Co-authored-by: Kévin Dunglas <kevin@dunglas.fr>
Co-authored-by: Kévin Dunglas <kevin@dunglas.fr>
Co-authored-by: Kévin Dunglas <kevin@dunglas.fr>
Co-authored-by: Kévin Dunglas <kevin@dunglas.fr>
@ES-Six ES-Six requested a review from dunglas October 30, 2021 20:45
@ES-Six
Copy link
Contributor Author

ES-Six commented Oct 30, 2021

All requested changes have been taken into account.

@dunglas dunglas merged commit 080334f into api-platform:2.6 Oct 30, 2021
@dunglas
Copy link
Member

dunglas commented Oct 30, 2021

Thanks!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants