feat: use JWT bundle's command to create keys #1448
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If this makes sense maybe the demo app's docker-entrypoint could benefit from it, too (with the |
dunglas
approved these changes
Oct 20, 2021
alanpoulain
approved these changes
Oct 20, 2021
Creation of directory and files is now covered by lexik/jwt-authentication-bundle's command. This somewhat causes the directory/file location to pop up out of nowhere in the subsequent permission change (`setfacl`). That could be avoided by extracting JWT_SECRET_KEY and JWT_PUBLIC_KEY from api's `.env` file (section maintained by the bundle) but it adds bloat without apparent benefit. The previously documented behaviour was closer to using the `--overwrite` option on the command, but I doubt it is in the user's best interest in a starter guide. Using `--skip-if-exists` would make some sense, but bailing feels like the sane option – the user obviously touched this area before and should be made aware. Resolves api-platform#1446 Co-authored-by: Kévin Dunglas <kevin@dunglas.fr>
|
Thanks! |
vincentchalamon
pushed a commit
to api-platform/demo
that referenced
this pull request
Nov 3, 2021
The idea was proposed in api-platform/docs#1446 and added to the docs in api-platform/docs#1448. The command was added to the bundle in v2.11. Composer install was moved first to ensure that the bundle is installed. This now attempts the permission modification (`setfacl`) irrespective of the previous existence of the key files. While the cost of this operation are certainly not zero, it ensures the permissions are as intended no matter how the key files came to be and leaves the configuration of the key file name entirely with the bundle/.env file.
billybrona
pushed a commit
to billybrona/symfony-demo
that referenced
this pull request
Nov 26, 2023
The idea was proposed in api-platform/docs#1446 and added to the docs in api-platform/docs#1448. The command was added to the bundle in v2.11. Composer install was moved first to ensure that the bundle is installed. This now attempts the permission modification (`setfacl`) irrespective of the previous existence of the key files. While the cost of this operation are certainly not zero, it ensures the permissions are as intended no matter how the key files came to be and leaves the configuration of the key file name entirely with the bundle/.env file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creation of directory and files is now covered by
lexik/jwt-authentication-bundle's command.
This somewhat causes the directory/file location somewhat pop up out of
nowhere in the subsequent permission change (
setfacl). That could beavoided by extracting JWT_SECRET_KEY and JWT_PUBLIC_KEY from api's
.envfile (section maintained by the bundle) but it adds bloat without apparent
benefit.
The previously documented behaviour was closer to using the
--overwriteoption on the command, but I doubt it is in the user's best interest in
a starter guide. Using
--skip-if-existswould make some sense, butbailing feels like the sane option – the user obviously touched this
area before and should be made aware.
Resolves #1446