Skip to content

Change annotations to attributes #1428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Oct 12, 2021
Merged

Change annotations to attributes #1428

merged 8 commits into from
Oct 12, 2021

Conversation

Catgolin
Copy link
Contributor

@Catgolin Catgolin commented Sep 9, 2021

Changed annotations into php 8 attributes in the admin and core pages.

Copy link
Member

@dunglas dunglas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for this tedious work!
Could you also rebase please?

@dunglas dunglas mentioned this pull request Oct 7, 2021
4 tasks
Catgolin and others added 7 commits October 8, 2021 12:18
@Catgolin Catgolin requested a review from dunglas October 9, 2021 18:44
@dunglas dunglas merged commit 29bffd0 into api-platform:2.6 Oct 12, 2021
@dunglas
Copy link
Member

dunglas commented Oct 12, 2021

Thank you very much!!

wiese added a commit to wiese/docs that referenced this pull request Oct 22, 2021
This seems to have slipped through in "Change annotations to attributes"
(api-platform#1428) when converting from annotations.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants