Skip to content

docs: 2.7 update #1422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 6, 2021
Merged

docs: 2.7 update #1422

merged 5 commits into from
Sep 6, 2021

Conversation

PommeThibaudeau
Copy link

@PommeThibaudeau PommeThibaudeau commented Sep 3, 2021

· php8 attributes instead of annotations.
· Removes item & collection operations
· ApiPlatform\Core\Annotation\ to ApiPlatform\Metadata
· forgotten file names

@dunglas
Copy link
Member

dunglas commented Sep 4, 2021

I would remove the strict type declaration as it's not related with API Platform (the library works well with or without enabling this feature).

Maybe could we mention somewhere that it's supported, or add them only in the getting started guide to show this as a best practice, but "polluting" every snippet with this declaration isn't worth it IMHO.

@PommeThibaudeau
Copy link
Author

I would remove the strict type declaration as it's not related with API Platform (the library works well with or without enabling this feature).

Maybe could we mention somewhere that it's supported, or add them only in the getting started guide to show this as a best practice, but "polluting" every snippet with this declaration isn't worth it IMHO.

I thought it would be nice to standardise these snippets but i could do the opposite, i.e. remove them all.

@soyuka soyuka merged commit e30d1e6 into api-platform:main Sep 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants