Configure Prettier. Adapt the Travis setup. #80
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
dunglas
commented
May 29, 2018
dunglas
commented
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | n/a |
| License | MIT |
| Doc PR | n/a |
soyuka
reviewed
May 29, 2018
.eslintrc.js
Outdated
| 'no-console': 0, | ||
| } | ||
| 'env': { | ||
| 'es6': true, |
soyuka
reviewed
May 29, 2018
.travis.yml
Outdated
| - '6' | ||
| - '10' |
There was a problem hiding this comment.
would sort because it makes me thing of @teohhanhui saying it to me 😆
soyuka
reviewed
May 29, 2018
| import ReactNativeGenerator from './generators/ReactNativeGenerator'; | ||
| import TypescriptInterfaceGenerator from './generators/TypescriptInterfaceGenerator'; | ||
| import VueGenerator from './generators/VueGenerator'; | ||
| import AdminOnRestGenerator from "./generators/AdminOnRestGenerator"; |
There was a problem hiding this comment.
I personally disagree with double quotes I find simple quotes easier to read.
There was a problem hiding this comment.
Me too, but... I prefer to not bother with that and use Prettier's default config.
soyuka
approved these changes
May 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.