Skip to content

Fix tests #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 29, 2018
Merged

Fix tests #77

merged 1 commit into from
May 29, 2018

Conversation

dunglas
Copy link
Member

@dunglas dunglas commented May 28, 2018

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets n:a
License MIT
Doc PR n/a

Well... Our test suite is buggy, and most tests are just useless.
This PR fixes them.

@dunglas dunglas requested review from soyuka and mysiar May 28, 2018 21:59
soyuka
soyuka approved these changes May 29, 2018
View reviewed changes
Copy link
Member

@soyuka soyuka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should introduce a linter anyway 👍

@dunglas dunglas merged commit 21ebd7f into api-platform:master May 29, 2018
@dunglas dunglas deleted the fix-tests branch May 29, 2018 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soyuka soyuka soyuka approved these changes

@mysiar mysiar Awaiting requested review from mysiar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dunglas @soyuka