refactor(metadata): type parameters to list<string>|string #7134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soyuka
force-pushed
the
fix/param-validation
branch
6 times, most recently
from
5fe4473 to
1a8366b
Compare
soyuka
force-pushed
the
fix/param-validation
branch
from
1a8366b to
0ebb1f0
Compare
lyrixx
reviewed
May 22, 2025
Comment on lines
+79
to
+100
| if ($value instanceof ParameterNotFound) { | ||
| return $value; | ||
| } | ||
|
|
||
| $isCollectionType = fn ($t) => $t instanceof CollectionType; | ||
| $isCollection = $parameter->getNativeType()?->isSatisfiedBy($isCollectionType) ?? false; | ||
|
|
||
| // type-info 7.2 | ||
| if (!$isCollection && $parameter->getNativeType() instanceof UnionType) { | ||
| foreach ($parameter->getNativeType()->getTypes() as $t) { | ||
| if ($isCollection = $t->isSatisfiedBy($isCollectionType)) { | ||
| break; | ||
| } | ||
| } | ||
| } | ||
|
|
||
| if ($isCollection) { | ||
| $value = \is_array($value) ? $value : [$value]; | ||
| } elseif ($parameter instanceof HeaderParameter && \is_array($value) && array_is_list($value) && 1 === \count($value)) { | ||
| $value = $value[0]; | ||
| } | ||
|
|
There was a problem hiding this comment.
Hello 👋
There is a BC break here.
On on resource, we have this (simplified version) :
#[ApiResource(
shortName: 'PublicDraft',
operations: [
new GetCollection(
parameters: new Parameters([
new QueryParameter(
key: 'triggerUrl',
constraints: [new Source()],
),
])
),
],
)]our request looks like this
curl --request GET \
--url 'https://api.redirection-io.test/app_dev.php/drafts?projectId=d98a60e4-56f4-11ea-8b8d-0242ac150003&triggerUrl=foobar' \
--header 'Authorization: Bearer 4781249f79bfbdfb1f3c11b2cfc88c5e1a434c9c579b19f5315ec5677051'
And in our validator, we use to receive a string, now we receive a array
We have symfony/type-info: 7.2.5 (but we do not reach line 88), because the $parameter->getNativeType is already a collection :
I tried to specify the nativeType, but I got the same result. It looks like it's not used.
nativeType: new BuiltinType(TypeIdentifier::STRING),There was a problem hiding this comment.
Oh, I missed #7157, sorry ! and the last release fixed it. Thanks!
There was a problem hiding this comment.
also parameters are experimental :D
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a nativeType to parameters, defaults to
list<string>|stringas this is the default with Symfony query parameters parsing and for HTTP Headers. It also fixes the value extraction accordingly and the validation that may have work partially on a value that's extracted as an array.TODO: