Reject only 5XX errors #27
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my previous commit, I added the possibility to reject promise if the response is incorrect. With the possibility, it was possible to manage authentication.
Unfortunately my commit brokes validations: when
fetchJsonLdretrieve a4XXresponse, it will reject the promise but in fetchHydra, we analyse only resolved promise.To solve issue api-platform/admin#68, I propose to:
5XXerrors or non valid response (same behaviors asfetch).4XXresponses will be resolved but parsing will fail so the promise will be reject (no change forapi-platform/admin).