feat: allow multiple actions in one ALTER TABLE statement
#960
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 6014479206
💛 - Coveralls |
Could they be represented by a Interestingly #959 is also related to mysql partition syntax |
alamb
approved these changes
Sep 7, 2023
There was a problem hiding this comment.
This looks great -- thank you @ForbesLindesay 🦾
Sorry for the delay in reviewing -- I was away last week.
| assert_eq!("foo", column_def.name.to_string()); | ||
| assert_eq!("TEXT", column_def.data_type.to_string()); | ||
| } | ||
| _ => unreachable!(), | ||
| }; | ||
|
|
||
| let rename_table = "ALTER TABLE tab RENAME TO new_tab"; | ||
| match verified_stmt(rename_table) { |
There was a problem hiding this comment.
This is a nice refactoring of the tests -- thank you
| @@ -588,6 +584,48 @@ fn parse_alter_table_alter_column() { | |||
| } | |||
| } | |||
|
|
|||
| #[test] | |||
| fn parse_alter_table_add_columns() { | |||
| self.peek_token(), | ||
| ); | ||
| }; | ||
| let operations = self.parse_comma_separated(Parser::parse_alter_table_operation)?; |
alamb
changed the title
ALTER TABLE statement
serprex
pushed a commit
to serprex/sqlparser-rs
that referenced
this pull request
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #675
I primarily focused on ensuring this follows the Postgres syntax: https://www.postgresql.org/docs/15/sql-altertable.html
This should largely work for MySql too though: https://dev.mysql.com/doc/refman/8.0/en/alter-table.html
One possible thing that could be worth considering is that MySql supports a list of "partition_options" after the "alter_options" and while the "alter_options" are comma-separated just like Postgres, the "partition_options" are separated by a space. I'm not sure how best to cleanly represent this in our current AST.