feat: support JSON keyword #799
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 4206604055
💛 - Coveralls |
AugustoFKL
reviewed
Feb 15, 2023
There was a problem hiding this comment.
Still trying to figure out this one, to be honest. I have two doubts...
- Why don't parse the creation of tables with json as well? You could add the parsing of the data type. It looks weird to me to have an unparsable data type.
- TBH, I never saw that structure of SQL, so I can't say shit about it. @alamb I think you're more capable of looking at this, sorry
alamb
approved these changes
Feb 17, 2023
There was a problem hiding this comment.
Thanks for the ping @AugustoFKL and thanks for the code @togami2864 -- looks good to me (it implements something bigquery specific) 👍
|
I took the liberty of merging this branch with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://cloud.google.com/bigquery/docs/reference/standard-sql/lexical#json_literals
support
jsonkeyword for json type in bigquery