Skip to content

fix: handle bigquery offset in map key #797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 21, 2023
Merged

fix: handle bigquery offset in map key #797

merged 3 commits into from
Jan 21, 2023

Conversation

Ziinc
Copy link
Contributor

@Ziinc Ziinc commented Jan 20, 2023

This PR adds in handling of the array subscript operator

@coveralls
Copy link

Pull Request Test Coverage Report for Build 3966204484

  • 19 of 19 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 85.957%
Totals Coverage Status
Change from base Build 3922998216: 0.02%
Covered Lines: 13203
Relevant Lines: 15360
💛 - Coveralls

alamb
alamb approved these changes Jan 21, 2023
View reviewed changes
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- thank you @Ziinc

@alamb alamb merged commit 4955863 into apache:main Jan 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alamb alamb alamb approved these changes

@filipecabaco filipecabaco filipecabaco approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Ziinc @coveralls @alamb @filipecabaco