Skip to content

fix(Dialect): fix a typo (precendence -> precedence) #794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 15, 2023

Conversation

SARDONYX-sard
Copy link
Contributor

No description provided.

Copy link
Contributor

@AugustoFKL AugustoFKL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

TBH not sure wether we should remove this variable. Is it used anywhere else? The underscore before the name is quite a bother

@AugustoFKL
Copy link
Contributor

@SARDONYX-sard could you please remove it?

@alamb
Copy link
Contributor

alamb commented Jan 15, 2023

TBH not sure wether we should remove this variable. Is it used anywhere else? The underscore before the name is quite a bother

I think _precedence is part of the Dialect trait definition. As you say I don't think it is actually used but it is passed to the trait in the parser, and users may have implemented the Dialect trait in their own projects and used the precedence argument.

https://github.com/sqlparser-rs/sqlparser-rs/blob/3f874f4ab8ad17f5149b57183436a4cdf4cf0704/src/parser.rs#L1583

Here are the other uses
https://github.com/search?q=repo%3Asqlparser-rs%2Fsqlparser-rs%20parse_infix&type=code

Thus I think we should keep it in the trait

@alamb
Copy link
Contributor

alamb commented Jan 15, 2023

Thank you @SARDONYX-sard and @AugustoFKL

@alamb alamb merged commit ca93941 into apache:main Jan 15, 2023
@coveralls
Copy link

Pull Request Test Coverage Report for Build 3887443423

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 85.941%

Totals Coverage Status
Change from base Build 3878132877: 0.0%
Covered Lines: 13185
Relevant Lines: 15342

💛 - Coveralls

@SARDONYX-sard SARDONYX-sard deleted the feature/fix-typo branch January 17, 2023 03:52
Ziinc pushed a commit to Logflare/sqlparser-rs that referenced this pull request Jan 20, 2023
* fix(Dialect): fix a typo

* fix: fix a typo in tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants