Skip to content

Redshift - Add support in sharp as start of the field name #485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 10, 2022

Conversation

yuval-illumex
Copy link
Contributor

The following query is valid in Redshift but not valid in Postgres:

SELECT #_of_users from users

@yuval-illumex yuval-illumex changed the title Add support in sharp Redshift - Add support in sharp as start of the field name May 8, 2022
@coveralls
Copy link

coveralls commented May 8, 2022

Pull Request Test Coverage Report for Build 2298821529

  • 8 of 8 (100.0%) changed or added relevant lines in 2 files are covered.
  • 545 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.02%) to 90.428%

Files with Coverage Reduction New Missed Lines %
tests/sqlparser_postgres.rs 1 99.87%
tests/sqlparser_common.rs 21 99.1%
src/ast/mod.rs 182 78.05%
src/parser.rs 341 82.99%
Totals Coverage Status
Change from base Build 2283154339: -0.02%
Covered Lines: 8257
Relevant Lines: 9131

💛 - Coveralls

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @yuval-illumex

cc @mskrzypkows who added this dialect in #471

@alamb
Copy link
Contributor

alamb commented May 10, 2022

Thanks @yuval-illumex

@alamb alamb merged commit 35f5f0b into apache:main May 10, 2022
ovr pushed a commit to cube-js/sqlparser-rs that referenced this pull request Sep 20, 2022
ovr pushed a commit to cube-js/sqlparser-rs that referenced this pull request Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants