Parse merge source as table factor #483
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 4, 2022 15:22
Some MERGE queries need a table as a soruce, added proper test showing it
mskrzypkows
commented
May 4, 2022
| source: Box<SetExpr>, | ||
| // Specifies alias to the table that is joined with target table | ||
| alias: Option<TableAlias>, | ||
| source: TableFactor, |
There was a problem hiding this comment.
@mobuchowski What do you think about this change?
alamb
approved these changes
May 9, 2022
There was a problem hiding this comment.
Looks good to me -- thank you @mskrzypkows
This PR looks like it has a merge conflict now
|
FYI I plan to release 0.17.0 tomorrow in case you want to work on this PR before then: #488 |
Pull Request Test Coverage Report for Build 2299529147
💛 - Coveralls |
…_merge_source_as_table_factor
OK, conflicts are resolved |
alamb
approved these changes
May 10, 2022
|
Thanks @mskrzypkows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some MERGE queries need a table as a source (not just a subquery), added proper test showing it
See https://docs.microsoft.com/en-us/sql/t-sql/statements/merge-transact-sql?view=sql-server-ver15 and https://www.postgresql.org/message-id/attachment/23520/sql-merge.html