Skip to content

add support for MERGE statement #430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 12, 2022
Merged

Conversation

mobuchowski
Copy link
Contributor

This PR adds support for MERGE statement based on the Snowflake syntax:
https://docs.snowflake.com/en/sql-reference/sql/merge.html

but should work with Hive based one neverthless.
https://cwiki.apache.org/confluence/display/hive/languagemanual+dml#LanguageManualDML-Merge

Signed-off-by: Maciej Obuchowski obuchowski.maciej@gmail.com

@coveralls
Copy link

coveralls commented Mar 7, 2022

Pull Request Test Coverage Report for Build 1971517694

  • 166 of 196 (84.69%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.1%) to 90.312%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/ast/mod.rs 31 42 73.81%
src/parser.rs 46 65 70.77%
Totals Coverage Status
Change from base Build 1953203878: -0.1%
Covered Lines: 7439
Relevant Lines: 8237

💛 - Coveralls

Signed-off-by: Maciej Obuchowski <obuchowski.maciej@gmail.com>
Signed-off-by: Maciej Obuchowski <obuchowski.maciej@gmail.com>
@mobuchowski mobuchowski force-pushed the add-merge-statement branch from d1088bc to 134fd6b Compare March 11, 2022 23:39
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me -- thank you @mobuchowski

@alamb alamb merged commit 6b55e51 into apache:main Mar 12, 2022
@coveralls
Copy link

coveralls commented Aug 25, 2024

Pull Request Test Coverage Report for Build 1971517694

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 166 of 196 (84.69%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.1%) to 90.312%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/ast/mod.rs 31 42 73.81%
src/parser.rs 46 65 70.77%
Totals Coverage Status
Change from base Build 1953203878: -0.1%
Covered Lines: 7439
Relevant Lines: 8237

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants