-
Notifications
You must be signed in to change notification settings - Fork 616
Support some of pipe operators #1759
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Part of apache#1758 Still missing - join - union|intersect|except - call - tablesample - pivot - unpivot
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @simonvandel! The changes look reasonable to me overall, left some comments
Hi @iffyio I'm sorry for the long response time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @simonvandel! left a common re error handling, otherwise the changes look good to me
@simonvandel could you take a look at the CI issues when you get the time? |
I think CI should be green with 89309c1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks @simonvandel!
cc @alamb
Part of #1758
Still missing (ran out of time today, can be done in follow-ups perhaps)
I'm a first time contributor - please let me know if there are better places to store the
PipeOperator
in the AST