Replace Method and CompositeAccess with CompoundFieldAccess
#1716
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI @goldmedal |
alamb
reviewed
Feb 18, 2025
| let expr = dialects.verified_expr( | ||
| "CONVERT(XML, '<Book>abc</Book>').value('.', 'NVARCHAR(MAX)').value('.', 'NVARCHAR(MAX)')", | ||
| ); | ||
| match expr { | ||
| Expr::Method(Method { expr, method_chain }) => { | ||
| assert!(matches!(*expr, Expr::Convert { .. })); | ||
| Expr::CompoundFieldAccess { root, access_chain } => { |
There was a problem hiding this comment.
it is nice to have a unified AST representation here
alamb
approved these changes
Feb 18, 2025
There was a problem hiding this comment.
Thanks @iffyio
I read through this PR -- and reviewed the test changes carefully. While I don't claim to understand all of the code, it looks quite a bit nicer and cleaner to me. 🚀
Thank you very much. Nice work
Also thank you @goldmedal for the review
|
Thanks for the reviews @alamb @goldmedal 🙏 |
|
Looks like this needs a merge up from main to resolve some conflicts |
|
Yeah I'll resolve the conflicts! |
iffyio
force-pushed
the
compound-expr
branch
from
b1a60fb to
3283d6e
Compare
ayman-sigma
pushed a commit
to sigmacomputing/sqlparser-rs
that referenced
this pull request
Apr 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #1551
This moves over two of the special case compound expressions delimited by period to use the new
CompoundFieldAccessrepresentation.It moves the logic to parse the various kinds of compound expression into the same function
parse_compound_expr, where previously they were somewhat spread between individual expression parsing and the compound field access parsing.