hive: support for special not expression `!a` and raise error for `a!` factorial operator #1472

wugeer · 2024-10-12T07:38:17Z

Closes: #1471
Closes: #1473

coveralls · 2024-10-16T16:30:01Z

Pull Request Test Coverage Report for Build 11685843065

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

68 of 78 (87.18%) changed or added relevant lines in 6 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.006%) to 89.39%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
src/dialect/hive.rs	1	2	50.0%
src/dialect/postgresql.rs	1	2	50.0%
src/dialect/mod.rs	2	4	50.0%
tests/sqlparser_common.rs	57	63	90.48%

Totals
Change from base Build 11651598157:	-0.006%
Covered Lines:	30567
Relevant Lines:	34195

💛 - Coveralls

src/dialect/mod.rs

src/parser/mod.rs

src/ast/operator.rs

src/parser/mod.rs

tests/sqlparser_hive.rs

wugeer · 2024-10-25T14:35:48Z

@iffyio Thank you for your suggestions—I learned a lot from them， I've resubmitted an updated version of the code. When you have a moment, could you please review it? Thanks!:)

src/parser/mod.rs

src/ast/operator.rs

src/parser/mod.rs

tests/sqlparser_hive.rs

wugeer · 2024-10-27T11:14:54Z

@iffyio Sorry, my oversight caused the code not to be merged. The code has been re-pushed.

src/dialect/mod.rs

src/dialect/hive.rs

src/parser/mod.rs

tests/sqlparser_common.rs

wugeer

Have Done! @iffyio

src/dialect/hive.rs

tests/sqlparser_common.rs

src/parser/mod.rs

tests/sqlparser_common.rs

iffyio

@wugeer just one comment I think was missed, otherwise this looks close, thanks!

src/parser/mod.rs

iffyio

LGTM! Thanks @wugeer!
cc @alamb

…r a! factorial operator in Hive dialect

Good Co-authored-by: Ifeanyi Ubah <ify1992@yahoo.com>

wugeer · 2024-11-08T13:03:23Z

@alamb Could you spare some time to review this PR? Thanks! :)

alamb

Looks good to me -- thank you @wugeer and @iffyio

wugeer force-pushed the fix_issue_1471 branch from c0fac44 to ab78bc2 Compare October 12, 2024 07:47

iffyio reviewed Oct 18, 2024

View reviewed changes

wugeer force-pushed the fix_issue_1471 branch from db466d2 to 2196dc1 Compare October 25, 2024 14:32

wugeer requested a review from iffyio October 25, 2024 14:35

iffyio reviewed Oct 27, 2024

View reviewed changes

src/parser/mod.rs Outdated Show resolved Hide resolved

src/ast/operator.rs Outdated Show resolved Hide resolved

src/parser/mod.rs Outdated Show resolved Hide resolved

src/parser/mod.rs Outdated Show resolved Hide resolved

tests/sqlparser_hive.rs Outdated Show resolved Hide resolved

wugeer requested a review from iffyio October 27, 2024 08:17

wugeer force-pushed the fix_issue_1471 branch 2 times, most recently from de68644 to 99910dd Compare October 27, 2024 11:05

iffyio reviewed Oct 30, 2024

View reviewed changes

wugeer commented Oct 30, 2024

View reviewed changes

src/dialect/hive.rs Show resolved Hide resolved

wugeer requested a review from iffyio October 30, 2024 14:29

iffyio reviewed Oct 31, 2024

View reviewed changes

tests/sqlparser_common.rs Outdated Show resolved Hide resolved

src/parser/mod.rs Outdated Show resolved Hide resolved

tests/sqlparser_common.rs Show resolved Hide resolved

wugeer force-pushed the fix_issue_1471 branch from 13a6889 to e64a717 Compare October 31, 2024 12:50

wugeer requested a review from iffyio October 31, 2024 12:50

iffyio reviewed Oct 31, 2024

View reviewed changes

src/parser/mod.rs Outdated Show resolved Hide resolved

wugeer requested a review from iffyio October 31, 2024 23:35

iffyio approved these changes Nov 1, 2024

View reviewed changes

wugeer force-pushed the fix_issue_1471 branch 3 times, most recently from deb38db to b0c789c Compare November 5, 2024 14:07

wugeer and others added 5 commits November 8, 2024 20:42

feat: add support for special bang not operator !a and raise error fo…

03df9d4

…r a! factorial operator in Hive dialect

Update src/dialect/mod.rs

773d369

Good Co-authored-by: Ifeanyi Ubah <ify1992@yahoo.com>

Modify the code according to the recommendations and add more test cases

15904d2

add parse_factorial_operator test and optimize redundant code

16c76e2

fix conflicts

38a4ea7

wugeer force-pushed the fix_issue_1471 branch from b0c789c to 38a4ea7 Compare November 8, 2024 12:58

alamb approved these changes Nov 13, 2024

View reviewed changes

alamb merged commit e857787 into apache:main Nov 13, 2024
8 checks passed

hive: support for special not expression !a and raise error for a! factorial operator #1472

hive: support for special not expression !a and raise error for a! factorial operator #1472

Uh oh!

Conversation

wugeer commented Oct 12, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coveralls commented Oct 16, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull Request Test Coverage Report for Build 11685843065

Warning: This coverage report may be inaccurate.

Details

💛 - Coveralls

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

wugeer commented Oct 25, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

wugeer commented Oct 27, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

wugeer left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

iffyio left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

iffyio left a comment

Choose a reason for hiding this comment

Uh oh!

wugeer commented Nov 8, 2024

Uh oh!

alamb left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

hive: support for special not expression `!a` and raise error for `a!` factorial operator #1472

hive: support for special not expression `!a` and raise error for `a!` factorial operator #1472

wugeer commented Oct 12, 2024 •

edited

Loading

coveralls commented Oct 16, 2024 •

edited

Loading