Skip to content

Support IN () syntax of SQLite, alternate proposal #1028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 29, 2023
Merged

Support IN () syntax of SQLite, alternate proposal #1028

merged 1 commit into from
Oct 29, 2023

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Oct 27, 2023

This is an alternate proposal for supporting IN () from SQLite, based on #1005 from @lewiszlw

image
SQLite3 supports in empty list expression.

Closes #1005

This PR

  1. Passes all tests from Support IN () syntax of SQLite #1005
  2. Is substantially fewer lines of code
  3. Includes a negative test

@alamb alamb mentioned this pull request Oct 27, 2023
Closed
lewiszlw
lewiszlw approved these changes Oct 28, 2023
View reviewed changes
Copy link
Member

@lewiszlw lewiszlw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We can go with this proposal.

@alamb
Copy link
Contributor Author

alamb commented Oct 29, 2023

Thank you @lewiszlw

@alamb alamb merged commit 4cdaa40 into apache:main Oct 29, 2023
@alamb alamb deleted the alamb/parse_where_in_empty_simpler2 branch April 9, 2024 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lewiszlw lewiszlw lewiszlw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alamb @lewiszlw