Support multiple PARTITION statements in ALTER TABLE ADD statement
#1011
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @bitemyapp -- This is on my list -- can you please resolve the CI failures and I'll take a look |
…i-partition-declarations
alamb
approved these changes
Oct 24, 2023
There was a problem hiding this comment.
Thank you for the contribution @bitemyapp -- I took the liberty of merge this branch up from main, fixing the compile error, and simplifying the logic.
tests/sqlparser_hive.rs
Outdated
|
|
||
| #[test] | ||
| fn parse_describe() { | ||
| let describe = r#"DESCRIBE namespace.`table`"#; |
There was a problem hiding this comment.
this I think was part of #1010, right?
There was a problem hiding this comment.
Yes sorry, this MR was based on top of 1010's because I was scrupulous/worried about accidentally having them trip over each other. I think that was a mistake and I should've kept the branches and patches independent of each other. Looks like it worked out anyway, thank you!
alamb
changed the title
PARTITION statements in ALTER TABLE ADD statement
Pull Request Test Coverage Report for Build 6626049286
💛 - Coveralls |
serprex
pushed a commit
to serprex/sqlparser-rs
that referenced
this pull request
Nov 6, 2023
apache#1011) Co-authored-by: Chris A <chrisa@indeed.com> Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revival of #657
Closes #657
Similar story to #1010
I compared the patches and nothing seemed to have changed significantly with the rebase. Please let me know what I'd need to do to make this merge-able. This patch includes #1010 so you could merge this one and close the other or merge the other first and then I can rebase this patch again.