feat: update datafusion dependency 47 #1107
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davisp
reviewed
Apr 22, 2025
robtandy
approved these changes
Apr 23, 2025
| @@ -698,8 +677,22 @@ pub fn approx_percentile_cont_with_weight( | |||
| add_builder_fns_to_aggregate(agg_fn, None, filter, None, None) | |||
| } | |||
|
|
|||
| aggregate_function_vec_args!(last_value); | |||
| // We handle first_value explicitly because the signature expects an order_by | |||
There was a problem hiding this comment.
Should this comment address first and last value?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
None
Rationale for this change
DataFusion 47 is updating upstream.
What changes are included in this PR?
Mostly small changes such as adding explicit types and accounting for API upstream changes.
Are there any user-facing changes?
None