chore: add src folder #362
Conversation
README.md
Outdated
| @@ -115,7 +115,7 @@ with excellent support for Angular apps that use routing. | |||
|
|
|||
| Here are the test related scripts: | |||
| * `npm test` - compiles, runs and watches the karma unit tests | |||
| * `npm run e2e` - run protractor e2e tests, written in JavaScript (*e2e-spec.js) | |||
| * `npm run e2e` - compiles and run protractor e2e tests, written in JavaScript (*e2e-spec.js) | |||
There was a problem hiding this comment.
Yes, and that means they need to be compiled. However what I actually wanted to say here (and didn't do it very well) is that running the command also compiles your app.
There was a problem hiding this comment.
Sorry I missed what you really meant. Fixed.
README.md
Outdated
| @@ -128,9 +128,9 @@ These tools are configured for specific conventions described below. | |||
| We recommend that you shut down one before starting another.* | |||
|
|
|||
| ### Unit Tests | |||
| TypeScript unit-tests are usually in the `app` folder. Their filenames must end in `.spec`. | |||
| TypeScript unit-tests are usually in the `src/app` folder. Their filenames must end in `.spec`. | |||
There was a problem hiding this comment.
Shouldn't they end on .spec.ts?
README.md
Outdated
| @@ -156,7 +156,7 @@ we configured protractor to find them. | |||
|
|
|||
| Thereafter, run them with `npm run e2e`. | |||
|
|
|||
| That command first compiles, then simultaneously starts the Http-Server at `localhost:8080` | |||
| That command first compiles, then simultaneously starts the Http-Server at `localhost:3000` | |||
There was a problem hiding this comment.
it is not http-server anymore, even if lite-server is a http server, I guess we could remove the - in there.
There was a problem hiding this comment.
Fixed by putting the package name explicitly.
| @@ -147,7 +147,7 @@ restart it. No worries; it's pretty quick. | |||
|
|
|||
| ### End-to-end (E2E) Tests | |||
|
|
|||
| E2E tests are in the `e2e` directory, side by side with the `app` folder. | |||
| E2E tests are in the `e2e` directory, side by side with the `src` folder. | |||
There was a problem hiding this comment.
I see them in an e2e folder and still same folder after this PR.
There was a problem hiding this comment.
The paragraph says they are in the e2e folder, and that it is a sibling folder to src. Did you misread or am I missing something?
| @@ -30,7 +30,6 @@ | |||
| // packages tells the System loader how to load when no filename and/or no extension | |||
| packages: { | |||
| app: { | |||
| main: './main.js', | |||
There was a problem hiding this comment.
what do we gain by removing this? I mean, if we are not importing "app" anymore, shouldn't we remove the entire app node?
There was a problem hiding this comment.
Doesn't work without that:
No description provided.