Skip to content
This repository was archived by the owner on Feb 26, 2024. It is now read-only.

Correction for when we change tsconfig.json/outDir and karma.conf/appBase #314

Merged
merged 1 commit into from
Dec 13, 2016
Merged

Correction for when we change tsconfig.json/outDir and karma.conf/appBase #314

merged 1 commit into from
Dec 13, 2016

Conversation

asfernandes
Copy link
Contributor

Usage of the variable currently works only because appBase and appSrcBase are defined to the same thing, but is conceptually incorrect.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@asfernandes
Copy link
Contributor Author

asfernandes commented Dec 9, 2016 via email

@googlebot
Copy link

CLAs look good, thanks!

@wardbell
Copy link
Contributor

Good catch. Thanks.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants