This repository was archived by the owner on Feb 26, 2024. It is now read-only.
chore: revise to conform to QS reboot in angular.io PR #2762 #287
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wardbell
force-pushed
the
quickstart-reboot
branch
2 times, most recently
from
8db469b to
541cde7
Compare
This was referenced Nov 18, 2016
|
@wardbell Without it, we don't have a chrome driver for Protractor to use when communication with chrome. That is the source of this error message in the CI: https://travis-ci.org/angular/quickstart/builds/176909767#L780 |
wardbell
force-pushed
the
quickstart-reboot
branch
3 times, most recently
from
4ab6761 to
d5a49ec
Compare
wardbell
force-pushed
the
quickstart-reboot
branch
2 times, most recently
from
34cc3f5 to
3d000f2
Compare
wardbell
force-pushed
the
quickstart-reboot
branch
from
3d000f2 to
5697600
Compare
|
Deleted "webdriver:update" from This works because npm itself detects any |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Coordinate with angular.io "QuickStart Reboot" PR #2782