This repository was archived by the owner on Feb 26, 2024. It is now read-only.
fix(e2e): restore e2e fix #271
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The "fix" is for the problem of running e2e tests in Travis. They ran fine locally before this commit. See angular/webdriver-manager#121 which describes how Travis is stuck on an old version of Chrome and ONLY by pinning to "old" versions of protractor and webdriver can we make tests pass in Travis. The sad consequence (for now) is that consumers of this QuickStart get an old, arguably "wrong" version of protractor and webdriver. We don't control Travis. We will fix as soon as possible. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #266