This repository was archived by the owner on Jul 29, 2024. It is now read-only.
display disableChecks option in extra flags error message #3964
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cnishina
suggested changes
Jan 12, 2017
| @@ -181,7 +181,7 @@ if (!argv.disableChecks) { | |||
| }); | |||
|
|
|||
| if (unknownKeys.length > 0) { | |||
| throw new Error('Found extra flags: ' + unknownKeys.join(', ')); | |||
| throw new Error('Found extra flags: ' + unknownKeys.join(', ') + ', please use --disableChecks flag to disable the custom flag check!'); | |||
There was a problem hiding this comment.
The wording could be improved.
please use --disableChecks flag to disable the Protractor CLI flag checks.
There was a problem hiding this comment.
Also, CircleCI does not like your typescript formatting. Please run npm run format before submitting.
There was a problem hiding this comment.
Yup, noticed that let me change & format it!
cnishina
approved these changes
Jan 12, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With reference to this recent SO question , it would be good to display the
--disableChecksoption in the error message thrown in case users have their own custom flags set in the cli.Users are not aware of this option until they check the changelog, it would help if this is displayed along with the error message thrown in the console itself.
@cnishina Since you worked on this, any thoughts?