5.1.0 breaks backwards compatibility with custom frameworks (calling `afterEach` is now required)

[jan-molak]

Hi @sjelin!

It seems like as of this commit custom frameworks have to call runner.afterEach after every test, even though the documentation states that this will be a requirement starting from Protractor 6.0.0.

We're adding support for this behaviour to Serenity/JS now to allow people to use Protractor 5.1.x, but I suppose the docs should be updated to clearly state that this is now a requirement?

---

To reproduce the problem, please install a custom framework, such as protractor-cucumber-framework and try to run several test scenarios with restartBrowserBetweenTests set to true.

The browser does not get restarted.

Calling runner.afterEach() after every test solves the issue.

(I see that you've requested support for this in protractor-cucumber-framework/protractor-cucumber-framework#67 by the way).

Best,
Jan

[sjelin]

The plan is for it to only be a requirement in 6.0. I am very surprised that 5.1 causes problems.

[sjelin]

Question: The same tests works in 5.0.0? And, in the tests you mentioned, is the control flow disabled?

[sjelin]

Actually, the only question is if the control flow is disabled. I could see how that change could be a problem if the control flow was disabled.

[jan-molak]

I tested the same scenario switching between 5.1.1 and 5.0.0, and yes, the same test works with 5.0.0; in both cases:

• the control flow is enabled (default settings).
• the browser is restarted between the tests

However, this only happens with custom frameworks that don't invoke the afterEach hook - such as protractor-cucumber-framework. The built-in ones are fine, and so is Serenity/JS now.

Please let me know if I can be of more help.

[sjelin]

This is very surprising. The behavior shouldn't have changed when the control flow is enabled.