This repository was archived by the owner on Jul 29, 2024. It is now read-only.
This repository was archived by the owner on Jul 29, 2024. It is now read-only.
Don't implicitly force use of WebDriver's ManagedPromise
#3903
Closed
Description
There are a couple different places, scattered throughout out codebase, where we force ManagedPromise
accidentally. As far as I've noticed, this happens in one of the following ways:
- We use
wdpromise.fulfilled
, which is actually deprecated. Luckily, we can just switch toWebDriver.promise.when
. We use(We only usewdpromise.defer
. We can get around this withnew wdpromise.controlFlow().promise(...)
, which follows the same syntax as for ES6 promises.wdpromise.defer
in the debugger, which has a separate issue: Debugger needs to work with the WebDriver control flow turned off #3901)(I may add to this list if I find more)(I did not)