Skip to content
This repository was archived by the owner on Jul 29, 2024. It is now read-only.
This repository was archived by the owner on Jul 29, 2024. It is now read-only.

Don't implicitly force use of WebDriver's ManagedPromise #3903

Closed
@sjelin

Description

@sjelin

There are a couple different places, scattered throughout out codebase, where we force ManagedPromise accidentally. As far as I've noticed, this happens in one of the following ways:

  • We use wdpromise.fulfilled, which is actually deprecated. Luckily, we can just switch to WebDriver.promise.when.
  • We use wdpromise.defer. We can get around this with new wdpromise.controlFlow().promise(...), which follows the same syntax as for ES6 promises. (We only use wdpromise.defer in the debugger, which has a separate issue: Debugger needs to work with the WebDriver control flow turned off #3901)
  • (I may add to this list if I find more) (I did not)

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions