This repository was archived by the owner on Dec 18, 2024. It is now read-only.
chore: send analytics data on all navigation ends #401
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
8 tasks
IgorMinar
reviewed
Feb 23, 2018
| (function(i,s,o,g,r,a,m){i['GoogleAnalyticsObject']=r;i[r]=i[r]||function(){ | ||
| (i[r].q=i[r].q||[]).push(arguments)},i[r].l=1*new Date();a=s.createElement(o), | ||
| m=s.getElementsByTagName(o)[0];a.async=1;a.src=g; | ||
| ~i.name.indexOf('NG_DEFER_BOOTSTRAP')|| // only load library if not running e2e tests |
There was a problem hiding this comment.
e2e tests run on local host or other non-prod host, this causes all the GA pings to be ignored/filtered out automatically. In other words, it's typically not necessary to treat e2e tests differently.
|
has this change been deployed? I don't see any pings from material.angular.io yet. thanks for making this change @josephperrott |
|
@IgorMinar This is now pushed, our first release of material.angular.io with this change was on Feb 27 around 10am PST, you should see data collected beginning then. |
|
yup. I see the data now in our reports. thanks!
…On Tue, Mar 6, 2018 at 10:12 AM Joey Perrott ***@***.***> wrote:
@IgorMinar <https://github.com/igorminar> This is now pushed, our first
release of material.angular.io with this change was on Feb 27 around 10am
PST, you should see data collected beginning then.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#401 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AANM6NUGt67hRLzWYbU2ReXvyT7cGXk-ks5tbtGmgaJpZM4SOGUs>
.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes angular/components#10022