This repository was archived by the owner on Feb 26, 2024. It is now read-only.
Null check on not found collection: issue #33 #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
|
I signed it! |
|
CLAs look good, thanks! |
wardbell
approved these changes
Sep 30, 2016
| @@ -437,7 +437,7 @@ export class InMemoryBackendService { | |||
| // tries to parse id as number if collection item.id is a number. | |||
| // returns the original param id otherwise. | |||
| protected parseId(collection: {id: any}[], id: string): any { | |||
| if (!id) { return null; } | |||
| if (!collection || !id) { return null; } | |||
| @@ -220,7 +220,7 @@ export class InMemoryBackendService { | |||
| if ('commands' === reqInfo.base.toLowerCase()) { | |||
| return this.commands(reqInfo); | |||
|
|
|||
| } else if (this.inMemDbService[reqMethodName]) { | |||
| } else if (this.inMemDbService[reqMethodName] && reqInfo.collection) { | |||
There was a problem hiding this comment.
No this this one. The override method should run whether reqInfo.collection is present or not.
|
Closing because PR #39 handles the approved change |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #33
Two changes, discussed here