Skip to content
This repository was archived by the owner on Feb 26, 2024. It is now read-only.

chore: update to @types #13

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions .npmignore
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,6 @@ gulpfile.js
.npmignore
tsconfig.json
tslint.json
typings
typings.json
.editorconfig
rollup.config.js
.travis.yml
1 change: 0 additions & 1 deletion .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ before_script:
install:
- npm install -g gulp
- npm install
- npm run typings install
script:
- npm run lint
- npm run tsc
Expand Down
6 changes: 1 addition & 5 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -180,11 +180,7 @@ compiling your application project.
`npm list --depth=0`

- consider updating typings, install individually/several:
`npm run typings -- install packagename --ambient --save`

**NB: Do not add to `npm postinstall` as that screws up consumers!**

- `npm run typings install`
`npm install @types/{core-js,jasmine,node} --save-dev`

- `npm run tsc` to confirm the project compiles w/o error (sanity check)

Expand Down
15 changes: 0 additions & 15 deletions gulpfile.js
Original file line number Diff line number Diff line change
Expand Up @@ -108,18 +108,3 @@ function runNgc(directory, done) {
done();
});
}

// WILL THIS WORK? DOES IT PROMPT?
function runTypings(done) {
var typingsjs = path.join(process.cwd(), 'node_modules/typings/dist/bin/typings');
var childProcess = cp.spawn('node', [typingsjs, 'install'], { cwd: process.cwd() });
childProcess.stdout.on('data', function (data) {
console.log(data.toString());
});
childProcess.stderr.on('data', function (data) {
console.log(data.toString());
});
childProcess.on('close', function () {
done();
});
}
10 changes: 6 additions & 4 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,7 @@
"start": "concurrently \"npm run tsc:w\" \"npm run lite\" ",
"test": "karma start karma.conf.js",
"build-and-test": "concurrently \"npm run tsc\" \"npm run test\"",
"http-server": "tsc && http-server",
"typings": "typings"
"http-server": "tsc && http-server"
},
"repository": {
"type": "git",
Expand Down Expand Up @@ -57,7 +56,6 @@
"lite-server": "^2.2.2",
"tslint": "^3.15.1",
"typescript": "^2.0.3",
"typings": "^1.4.0",

"canonical-path": "0.0.2",
"http-server": "^0.9.0",
Expand All @@ -82,6 +80,10 @@

"vinyl-source-stream": "^1.1.0",
"rollup": "^0.36.0",
"rollup-stream": "^1.14.0"
"rollup-stream": "^1.14.0",

"@types/core-js": "^0.9.34",
"@types/jasmine": "^2.5.35",
"@types/node": "^6.0.45"
}
}